[GitHub] httpcomponents-core issue #49: HeaderGroup uses a ReadWriteLock for access t...

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] httpcomponents-core issue #49: HeaderGroup uses a ReadWriteLock for access t...

cakofony
Github user cakofony commented on the issue:

    https://github.com/apache/httpcomponents-core/pull/49
 
    Makes sense.
   
    I used the `AbstractClassicEntityConsumer<InputStream>` and simply returned the response body InputStream, nested in a `BasicResponseConsumer` where I returned a tuple of the HttpResponse and InputStream body.
    Removing headers occurrend in my `FutureCallback<Message<HttpResponse, InputStream>>`, where I check if the content is gzip encoded.
   
    It sounds like I may be able to avoid the race by moving that logic from the FutureCallback into the BasicResponseConsumer?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...